geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

GO terms with EC:1.7.1.* xrefs #23291

Closed sjm41 closed 2 years ago

sjm41 commented 2 years ago

According to their EC xrefs, the three GO terms below should have their is_a parent changed to: id: GO:0046857 name: oxidoreductase activity, acting on other nitrogenous compounds as donors, with NAD or NADP as acceptor xref: EC:1.7.1.-

id: GO:0003920 name: GMP reductase activity def: "Catalysis of the reaction: IMP + NADP(+) + NH(4)(+) = GMP + 2 H(+) + NADPH." [EC:1.7.1.7, RHEA:17185] xref: EC:1.7.1.7 is_a: GO:0016657 ! oxidoreductase activity, acting on NAD(P)H, nitrogenous group as acceptor

id: GO:0033739 name: preQ1 synthase activity def: "Catalysis of the reaction: 7-aminomethyl-7-deazaguanine + 2 NADP(+) = 7-cyano-7-deazaguanine + 3 H(+) + 2 NADPH." [EC:1.7.1.13, RHEA:13409] xref: EC:1.7.1.13 is_a: GO:0016646 ! oxidoreductase activity, acting on the CH-NH group of donors, NAD or NADP as acceptor is_a: GO:0016657 ! oxidoreductase activity, acting on NAD(P)H, nitrogenous group as acceptor

id: GO:0034556 name: nitrobenzoate nitroreductase activity def: "Catalysis of the reaction: o-nitrobenzoate + NADPH + H+ = o-hydroxylaminobenzoate + NADP+." [UM-BBD_reactionID:r0849] xref: EC:1.7.1.- is_a: GO:0016657 ! oxidoreductase activity, acting on NAD(P)H, nitrogenous group as acceptor

pgaudet commented 2 years ago

'GO:0016657 ! oxidoreductase activity, acting on NAD(P)H, nitrogenous group as acceptor' corresponds to https://enzyme.expasy.org/EC/1.6.6.-

All the subclasses of 1.6.6.- have been deleted or transferred. So GO:0016657 should also been obsoleted.

pgaudet commented 2 years ago
pgaudet commented 2 years ago

Created a new ticket for the issue with GO:0016657 - https://github.com/geneontology/go-ontology/issues/23357

sjm41 commented 2 years ago

Thanks @pgaudet ! I might be misinterpreting the commit, but do you still need to change the parent on GO:0034556 nitrobenzoate nitroreductase activity?

pgaudet commented 2 years ago

yes thanks ! now done