geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
222 stars 40 forks source link

Missing parent: [GO term] regulation of biological quality #24125

Open ValWood opened 2 years ago

ValWood commented 2 years ago

Lots of issues with the "regulation of biological quality" branch, but it seems the best parent for these terms:

GO:0031413 regulation of buoyancy GO:0060378 regulation of brood size

balhoff commented 2 years ago

Both of these should be classified automatically under there, but they have logical definitions that refer to obsolete terms. I would have expected this to be caught in a check; I'll look into it.

balhoff commented 2 years ago

Both of those terms referenced OBA biological attributes that have been obsoleted and moved to PATO. But our 'regulation of biological quality' pattern (https://github.com/geneontology/go-ontology/blob/master/docs/patterns/regulation_of_characteristic.md) specifies 'biological attribute' as the filler range, not any PATO characteristic/quality. For that reason these two terms still don't classify under 'regulation of biological quality'. We can discuss changing the pattern in our upcoming design patterns discussion.

pgaudet commented 11 months ago

At the Jan 2021 (?) jamboree we had discussed to obsolete this branch, this is a bunch of phenotypes.

I would be tempted to close this for now, as this is a huge project.

pgaudet commented 11 months ago

https://www.ebi.ac.uk/QuickGO/annotations?goUsage=descendants&goUsageRelationships=is_a,part_of,occurs_in&goId=GO:0065008&evidenceCode=ECO:0000269&evidenceCodeUsage=descendants

ValWood commented 11 months ago

It probably isn't as huge as it seems. Many of these terms just need this parentage removed. That could be a first step. This would be an improvement because it would mean that terms like vasodilation, lactation, lumen formation, ecdysone biosynthetic process, open tracheal system etc etc, would no longer be is_a biological regulation

pgaudet commented 11 months ago

Right !