geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

NTR mRNA phosphatase activator activity #24720

Open pgaudet opened 1 year ago

pgaudet commented 1 year ago

To replace GO:1990521 | m7G(5')pppN diphosphatase activator activity, see #23290

PMID:22323607

ValWood commented 1 year ago

change parent to phosphatase activator activity (I can do this today)

ValWood commented 1 year ago

I changed "Subclass of" enzyme regulator activity -phosphatase regulator activity I removed direct subclass catalytic activity"

However, this term has an equivalence axiom from a design pattern (I think?) that is placing mRNA phosphatase activator activity" directly under catalytic activity- which is incorrect?

@pgaudet could you take a look? When I switch of the asserted links the positioning is fin, under "molecular function regulator"

I will check in my changes now.

pgaudet commented 1 year ago

For reference; this is the term @edwong57 created:

[Term] id: GO:0170008 name: mRNA phosphatase activator activity namespace: molecular_function def: "Binds to and increases the activity of mRNA phosphatase." [PMID:22323607] is_a: GO:0003824 ! catalytic activity is_a: GO:0098772 ! molecular function regulator activity intersection_of: GO:0098772 ! molecular function regulator activity intersection_of: directly_positively_regulates GO:0140818 ! mRNA 5'-phosphatase activity property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/24720 xsd:anyURI created_by: ew creation_date: 2023-01-25T18:31:14Z

pgaudet commented 1 year ago

@ValWood


  1. Indeed this should not be is_a catalytic activity
  2. The mRNA phosphatase is a pyrophosphatase, not a phosphatase (see explanation here: https://github.com/geneontology/go-ontology/issues/23401
ValWood commented 1 year ago

So a pyrophosphatase isn't a type of phosphatase? In that case we would need to change this term label to

mRNA pyrophosphatase activator activity and put it back under enzyme activator activity.

Let me know, if so I can do that.

ValWood commented 1 year ago

I'm still a bit confused by this.

RE comment

The mRNA phosphatase is a pyrophosphatase, not a phosphatase

but it is still called mRNA phosphatase activator, and defined binds to and increases the activity of an mRNA phosphaste.

Also the logical def is different (refers to mRNA 5' phosphatase), os it is inconsistent?

ValWood commented 1 year ago

Still looks like this?

_MP_
ValWood commented 1 year ago
_MP