geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

BP for calcium ion importer #24965

Closed ValWood closed 8 months ago

ValWood commented 1 year ago

I have 3 term choices

______FRIDAY GO TRACKER

@pgaudet what is the preferred solution? Can I add Calcium ion import across plasma membrane into cytosol (or does import imply import into cell- this isn't necessarily how it is used, I see it used also for ER->cytosol)

pgaudet commented 1 year ago

There are a lot of inconsistencies in that branch.

To me, just 'import' doesn't mean anything, it could be 'import into cell', 'import into ER', vacuole etc

I thought for a while that 'import across the plasma membrane' was better for bacteria and plants, because many of the transporters are at the plasma membrane, but maybe the best is 'import into cell'

'calcium import into cytosol' is not clear enough, it can mean from the extracellular medium or from intracellular stores.

Specifically for calcium, there seems to be way too many terms already. Should we look at that on one of our calls?

Pascale

ValWood commented 1 year ago

Yes, no hurry I just want to annotate them consistently.

ValWood commented 10 months ago

I will add the term I needed calcium ion import across plasma membrane

ValWood commented 9 months ago

calcium ion import across plasma membrane exists but does not have the import parents listed above

ValWood commented 9 months ago

Calcium import across plasma membrane should be a child of calcium ion import and calcium ion import into cytosol

(these two terms should perhaps be 'transmembrane' terms but that can be looking into later. \

I will add the missing parent here to suppress summarize the annotation better, and make the specific term findable

Screenshot 2023-12-01 at 17 09 26
ValWood commented 8 months ago

ACTION: GO:0098703 is_a GO:0070509 GO:0098703 is_a GO:1902656

pgaudet commented 8 months ago

I would lean towards obsoleting GO:0070509 calcium ion import (and all "import" terms that dont mention where a substrate is imported), as well as 'GO:1902656 calcium ion import into cytosol', since that includs both import from extracellular and import from calcium stores.

Most likely the term curators were trying to use was calcium import across plasma membrane.

ValWood commented 8 months ago

I agree, I only added these to fix a short term problem of function predictions. But all substrate specific transport needs review/merge. I was worried it might take longer than the next batch of function predictions ;) Plus it's easier to do the obsolete and replace if the child terms are in the correct place (unless these had been isolated because the obsoletion was already in progress?)