geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

Obsoletion request: redundant descendants of [GO ID:GO:0032187 actomyosin contractile ring localization] #25379

Closed ValWood closed 1 year ago

ValWood commented 1 year ago

Please provide as much information as you can: Follow on from https://github.com/geneontology/go-ontology/issues/21834

Branch has only 10 EXP annotations 6 PomBase 1 CGD 3 FlyBase

See above for replaced by


Checklist for ontology editor

Check term usage and metadata in Protégé

Check annotations

Notification

ValWood commented 1 year ago

@pgaudet since this is a merge do I don't need an annotation tracker ticket, correct? Just an obsoletion notice?

ValWood commented 1 year ago

I will go ahead with this today since there will be automatic replacement.

ValWood commented 1 year ago

Check graph still need to deal with GO:0032187 | actomyosin contractile ring localization (this one has a taxon restriction)

and consider maintenance (is this a phenotype only, does the ring move unless a mutant?)

pgaudet commented 1 year ago

Sorry I had missed that

since this is a merge do I don't need an annotation tracker ticket, correct? Just an obsoletion notice?

You need to send a review ticket, not all groups have procedures for automated replacements. Everyone editing in Noctua and P2GO is OK; other groups need to be notified.

Thanks, Pascale

ValWood commented 1 year ago

So, this list will be OK? 6 PomBase 1 CGD 3 FlyBase

Which groups don't use Noctua or P2GO apart from PomBase and PHI-base, Eco-Cyc?

pgaudet commented 1 year ago

EcoCyc EcoWiki TAIR CGD ComplexPortal/IntAct InterPro Reactome SP keywords RNA central SynGO GeneDB HPA PseudoCAP DisProt SGN

I think that's about it

ValWood commented 1 year ago

Dear @marekskrzypek @jlewsmith

There is a single CGD annotation to IQG1 |   |   | actomyosin contractile ring localization |   | CGD | Candida albicans SC5314 | IMP

The branch GO:0007105 cytokinesis, division site positioning was duplicated with equivalent terms.

This term will be obsoleted with the replacement term: GO:0007105 cytokinesis, division site positioning

We can no longer merge terms which are equivalent, they need to be obsoleted.

If the term was used to describe an evolved process you can just migrate the annotation to the remaining term. Or, if the paper is describing detachment and migration of the ring after it is formed at a particular localization, this represents an aberrant mutant phenotype and not an evolved process.

ValWood commented 1 year ago

@hattrill just to check that you already updated your annotations as per https://github.com/geneontology/go-ontology/issues/21834 I still see them. v

hattrill commented 1 year ago

Hi @ValWood , Sorry, thought there was going to be a merge. Will review them now.

ValWood commented 1 year ago

Oh actually, it's OK, if. you use protein2GO they will be migrated to the new term. It isn't a merge but it's equivalent to a merge.

hattrill commented 1 year ago

Cool. Actually, good for me to look at them as one needed to be removed. All done now.

One thing I noticed was that we have a term for mitosis: mitotic cytokinesis, division site positioning but not the equivalent for the meiotic branch

might be a deliberate ommission or something that isn't needed cos of GO-CAMs...but thought that I'd mention it.

jlewsmith commented 1 year ago

Hi Val,

I'll take a look at the paper and make the appropriate change.

Thanks, Jodi

ValWood commented 1 year ago

One thing I noticed was that we have a term for mitosis: mitotic cytokinesis, division site positioning but not the equivalent for the meiotic branch

The reason for this is that most of the work on cytokinesis has been done in yeast. In yeast the process of "cytokinesis" is very different, (because basically the cell forms spores around the segregated DNA, rather than an actomyosin contractile ring and a septum). All of the yeast annotations are for mitotic cytokinesis. There are only 160 EXP annotations to meiotic cytokinesis, so I suspect it's just that the terms have not been required yet due to depth of study.

ValWood commented 1 year ago

Will open another ticket for the remaining 3 terms that appear to be redundant.

ValWood commented 1 year ago

Follow up is in https://github.com/geneontology/go-ontology/issues/25606