geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

Review problem taxon constraints #25400

Closed balhoff closed 1 year ago

balhoff commented 1 year ago

I removed these constraints from only_in_taxon.tsv because they slipped through QC checks and were causing unsatisfiable classes:

GO:0010098  suspensor development   NCBITaxon:6072  Eumetazoa
GO:0031154  culmination involved in sorocarp development    NCBITaxon:33680 Myxogastria 
GO:0031152  aggregation involved in sorocarp development    NCBITaxon:33680 Myxogastria 
GO:0099138  altruistic chimeric sorocarp development    NCBITaxon:33680 Myxogastria 

One reason is that Myxogastria wasn't yet in our taxon import.

pgaudet commented 1 year ago

GO:0010098, suspensor development >> suspensor is a plant structure ; do we inherit TC from PO? Others (GO:0031154, GO:0031152, GO:0099138) are currently Only in Taxon | 33083 | Dictyostelia, which is a Eumycetozoa, not a Myxogastria

The common parent would be Evosea

@ValWood how did you pick up these as terms needing TCs? (since they already had TCs...)

Thanks, Pascale

ValWood commented 1 year ago

They came through the function prediction pipeline. They did make predictions on obsolete terms too, but I thought that I checked them all. The suspensor development doesn't have one.

It's weird that I would put these 3 anyway since the taxon constraint would go on the parent "sorocarp development" not on each child. I think I must have mixed up my checked list with the list of all the terms which had predictions.

pgaudet commented 1 year ago

We may get a TC from PO for GO:0010098, suspensor development - I dont dare loading the Protégé plugin

I think @dustine32 generates a full list of all TCs for PAINT - @dustine32 is there some place we can access a current version of this file?

Thanks, Pascale

ValWood commented 1 year ago

I don't see a tax constraint for GO:0010098, suspensor development in QuickGO though. I would see it there from any source wouldn't I?

pgaudet commented 1 year ago

No, quickgo does not show TC coming outside of GO.

Le mar. 23 mai 2023, 09:42, Val Wood @.***> a écrit :

I don't see a tax constraint for GO:0010098, suspensor development in QuickGO though. I would see it there from any source wouldn't I?

— Reply to this email directly, view it on GitHub https://github.com/geneontology/go-ontology/issues/25400#issuecomment-1558712041, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEPWUCO2NX2RGNFOGMEPKDXHRS6PANCNFSM6AAAAAAYFWZBLU . You are receiving this because you commented.Message ID: @.***>

dustine32 commented 1 year ago

@pgaudet Here is the current file used by PAINT, generated using gaferencer and based on the 2023-03-06 GO release ontology: http://data.pantherdb.org/TaxonConstraints/TaxonConstraintsLookup.txt

A newer file based on the 2023-05-10 GO ontology should be available in a few days.

balhoff commented 1 year ago

@pgaudet @ValWood

image

pgaudet commented 1 year ago

Thanks @balhoff - @ValWood this is what the taxon plugin does (but it makes Protégé very slow)

ValWood commented 1 year ago

Can this be closed?

balhoff commented 1 year ago

@ValWood if you are satisfied with the taxon constraints on those terms, then yes please close.

ValWood commented 1 year ago

The sorocarp terms have constraints. GO:0010098 suspensor development doesn't

@pgaudet mentions above this may come from PO. I don't know how that works. Happy to close if it will come from elsewhere.