geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
222 stars 40 forks source link

Remove logical definition from GO:0022414 reproductive process #27054

Closed pgaudet closed 7 months ago

pgaudet commented 8 months ago

Remove logical definition from GO:0022414 reproductive process

cmungall commented 8 months ago

This is a band-aid over the fact that having two concepts for "reproductive process" and "reproduction" only makes sense to ontologists (insofar as we have these two concepts, the logical definition is actually correct).

My favored solutions in order:

  1. obsolete "reproductive process". It provides zero information.
  2. place a do_not_annotate on "reproductive process"
  3. remove the logical definition

But any solution is better than none.

These are the direct annotations by evidence:

image

All the experimentals are unsurprisingly IMP:

image

I think these can easily be moved down to reproduction. This means there is no obstacles to either 1 or 2.

pgaudet commented 8 months ago

OK - last time I checked I got stuck in the of moving all children to other parents; they cannot all move to is_a reproduction (but this is the general for a x process terms, for example this is why we have 'apoptotic process' and not 'apoptosis'

'acrosome reaction' 'cellular process involved in reproduction in multicellular organism' dehiscence 'developmental process involved in reproduction' 'embryo implantation' 'embryonic process involved in female pregnancy' fertilization 'fetal process involved in parturition' 'gamete generation' 'gonad development' 'mammalian oogenesis stage' 'maternal process involved in female pregnancy' 'maternal process involved in parturition' 'mating plug formation' 'meiotic cell cycle' 'meiotic cell cycle process' 'meiotic drive' 'menstrual cycle' 'mucilage extrusion from seed coat' 'multi-organism reproductive process' 'multicellular organismal reproductive process' ovulation 'ovulation cycle' 'ovulation cycle process' 'penile erection' pollination 'positive regulation of flagellated sperm motility involved in capacitation' 'premature acrosome loss' 'reproductive process in single-celled organism' 'reproductive shoot system development' 'seed maturation' 'seminal clot liquefaction' 'sperm ejaculation' 'sperm motility'

pgaudet commented 8 months ago

I removed the LD for reproductive process. I'll leave this open for obsoletion of reproductive process, but I am not sure where to move all the children.

raymond91125 commented 8 months ago

I removed the LD for reproductive process. I'll leave this open for obsoletion of reproductive process, but I am not sure where to move all the children.

https://github.com/geneontology/go-ontology/pull/27063

raymond91125 commented 8 months ago

I actually think "reproductive process" is a better term than "reproduction" as defined. Reproductive process is defined as "A biological process that directly contributes to the process of producing new individuals by one or two organisms. The new individuals inherit some proportion of their genetic material from the parent or parents." In fact, "reproduction" has an exact synonym "reproductive physiological process". I suggest that we obsolete reproduction as it has the mixed meaning of the end goal and the process with the definition "The production of new individuals that contain some portion of genetic material inherited from one or more parent organisms."

pgaudet commented 8 months ago

Ontology call: agree to replace "reproduction" by "reproductive process"

pgaudet commented 8 months ago

Also please replace

pgaudet commented 8 months ago

Add DO NOT ANNOTATE on GO:0022414 reproductive process and other GO:0032504 multicellular organism reproduction and GO:0032505 reproduction of a single-celled organism b

raymond91125 commented 8 months ago

@pgaudet Should I simply transfer the slims over to reproductive process?

pgaudet commented 7 months ago

@raymond91125

Should I simply transfer the slims over to reproductive process?

Yes, thanks