geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

terms misusing 'results in specification of' #28016

Closed balhoff closed 3 months ago

balhoff commented 3 months ago

We have a couple of terms using results in specification of in their logical definitions. The range of this property is cell, but we are using it for plant organ specification. The new ELK reasoner catches this problem in the go-lego build, where we have a bridge from plant cell to CL cell. The terms are:

Could we change to results in structural organization of?

We will need to fix this in order to move to the new Protege and ODK.

pgaudet commented 3 months ago

@tberardini Does that work ?

tberardini commented 3 months ago

@pgaudet What would the new logical definition look like?

'results in structural organization of' 'floral organ identity' seems odd since floral organ identity is not an entity that is organized

'results in structural organization of' 'floral organ' doesn't quite capture the identity part

Maybe we need to just drop the logical def for these terms. I'm not familiar enough with RO to pick another relation.

ukemi commented 3 months ago

Is this a type of regionalization, defining the pattern where the floral organ cells will differentiate. Isn't this specified by homeotic genes? @tberardini, I think we looked at this a looooong time ago when comparing plants and animals?

tberardini commented 3 months ago

Yes, floral homeotic genes take care of the specification of identify (petal vs. sepal vs. carpel vs. stamen) see 2014 paper (figure 1): https://academic.oup.com/jxb/article/65/1/1/431211

Depending on which combination of transcription factor complexes are expressed, you get a different floral organ.

balhoff commented 3 months ago

I think dropping the logical definitions might be a solution. We could add a weaker relation to the GO terms using the parent property results in developmental progression of in order to keep the link to the PO terms.

tberardini commented 3 months ago

sounds ok to me