geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

Taxon constraints should propagate over 'regulates' #29010

Open pgaudet opened 2 months ago

pgaudet commented 2 months ago

Hi @balhoff

Now that we have a new relation to express regulation in another organism, we can propagate taxon constraints over the 'regulates' relation. This doesn't seem to be happening, see

image

has no taxon constraints

but the 'non-regulatory' parent does:

image image
pgaudet commented 2 months ago

And once that is done, we should remove any asserted TCs on the regulation terms, to make sure TCs are consistent, or define cases where there should be exceptions.

balhoff commented 1 month ago

We have two terms with problems when we propagate 'in taxon' over 'regulates':

envenomation resulting in plasminogen activation in another organism SubClassOf Nothing

suppression by virus of host natural killer cell activation SubClassOf Nothing

pgaudet commented 1 month ago

Hopefully that will fix the issue.

Thanks, Pascale

balhoff commented 1 month ago

Thanks @pgaudet looks like those changes do clear the problems.