geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
221 stars 40 forks source link

Obsoletion request: cellular metabolic process and regulation of cellular metabolic process terms #29021

Closed edwong57 closed 5 days ago

edwong57 commented 2 weeks ago

Please provide as much information as you can:

The reason for obsoletion is that these terms are redundant terms to:

Related to clean up of cellular process terms - https://github.com/geneontology/go-ontology/issues/28908

7 mappings/cross refs to review


Checklist for ontology editor

Check term usage and metadata in Protégé

Check annotations

Notification

deustp01 commented 2 weeks ago

Four Reactome pathways fixed as suggested (but is this this suggested term correct? GO:0006521 regulation of amino acid metabolic process)

edwong57 commented 2 weeks ago

Which Reactome pathways are they? What were the annotations?

I think the idea is that since metabolic process has been moved under 'cellular process' that 'regulation of amino acid metabolic process' has 'cellular process' as a parent and there's no need to have a separate 'regulation of cellular amino acid metabolic process' term. So, parentage-wise, I don't think that those should change going from 'regulation of cellular amino acid metabolic process' to 'regulation of amino acid metabolic process,' if that was your concern.

deustp01 commented 2 weeks ago

Which Reactome pathways are they? What were the annotations?

The GO BP terms associated with Reactome pathways R-HSA-1428517 "Aerobic respiration and respiratory electron transport", R-HSA-163675 "ChREBP activates metabolic gene expression", R-HSA-74182 "Ketone body metabolism", and R-HSA-350562 "Regulation of ornithine decarboxylase (ODC)", each needed updating to replace a cellular~ term with a plain metabolism one; no arguments from here about the metabolism versus cellular-metabolism distinction. The failure of the usage survey done as part of a GO obsoletion to pick up these Reactome instances is a known problem due to how we capture the BP terms and export that information in a GAF, that we are slowly working on.

pgaudet commented 2 weeks ago

Hi @deustp01

The TAS and NAS are now included in the reports. I thought this would result in Reactome's annotations being included in reports. Can you give a specific example of an annotation you expect to be reported that was missing? Looks like we may need to fix something else.

Thanks, Pascale

deustp01 commented 2 weeks ago

Can you give a specific example of an annotation

The three BP-to-pathway annotations in my last comment. @ukemi is the planned cross-referencing of Reactome pathways (rather than reactions) to GO terms relevant / helpful here? I guess that it is but can't explain clearly.

srengel commented 1 week ago

looks like these changes have already been made, but the email said we have until Oct14th.

edwong57 commented 1 week ago

The terms listed in this ticket are still showing up in protege and the latest go-edit.obo, so it doesn't look like these have been obsoleted. I didn't tag SGD in the annotation review since the annotations should be replaced automatically with Noctua. I can assign someone, but thought it was unnecessary since it was going to be done computationally.

I did obsolete a few precomposed terms (20919 and 20920) that only had PomBase annotations after those got cleaned up.