geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
216 stars 39 forks source link

taxon constraints redundancies #7848

Closed gocentral closed 8 years ago

gocentral commented 13 years ago

Tony spotted some redundancies in the taxon constraints file. My inclination is to remove the stronger axiom in all cases but I thought I'd check with folks

[Term] id: GO:0009291 name: unidirectional conjugation relationship: only_in_taxon NCBITaxon:2 ! Bacteria

[Term] id: GO:0009291 name: unidirectional conjugation relationship: only_in_taxon NCBITaxon_Union:0000004 ! Prokaryota

no idea, but my inclination is to go with the second weaker constraint

[Term] id: GO:0001701 name: in utero embryonic development relationship: only_in_taxon NCBITaxon:32525 ! Theria

[Term] id: GO:0001701 name: in utero embryonic development relationship: only_in_taxon NCBITaxon:40674 ! Mammalia

I recall a discussion with Mike L are there any monotremes with a uterus?

[Term] id: GO:0030141 name: secretory granule relationship: never_in_taxon NCBITaxon:4751 ! Fungi

[Term] id: GO:0030141 name: secretory granule relationship: never_in_taxon NCBITaxon:4890 ! Ascomycota

no idea but weaker seems safest

Reported by: cmungall

Original Ticket: geneontology/ontology-requests/7632

gocentral commented 13 years ago

For the first one, yes go with the weaker constraint (that's actually a new one - looks like it accidentally got added twice).

Second one, no idea, monotremes definitely aren't placental but not sure about a uterus. It could be that the only_in_taxon NCBITaxon:32525 ! Theria one was supposed to be never_in? Have asked David.

The last one is another new one that got added twice...I'd go with the weaker.

Original comment by: jl242

gocentral commented 13 years ago

Okay, for the second one we need to delete the only_in_taxon NCBITaxon:40674 ! Mammalia stanza - monotremes don't have a placenta.

We also need to fix this one:

[Term] id: GO:0042297 name: vocal learning relationship: only_in_taxon NCBITaxon:9126 ! Passeriformes

because mammals exhibit vocal learning too (e.g. humans!).

Original comment by: jl242

gocentral commented 13 years ago

Okay - I had the file open anyway so I just committed these changes.

Original comment by: jl242

gocentral commented 13 years ago

Original comment by: jl242