delete json-model property

geneontology / go-shapes

Schema for Gene Ontology Causal Activity Models defined using RDF Shapes

2 stars 0 forks source link

delete json-model property #231

Closed goodb closed 3 years ago

goodb commented 3 years ago

Some older models are failing the model metadata validation because they have data hanging off of the property http://geneontology.org/lego/json-model

I believe the data there should be deleted from the models as it is not used in the current infrastructure. @kltm confirm?

Broader question. Is it a good time to clean up the models in the repo? Deleting test models, fixing broken production models etc. ? If we were to want to advertise the noctua-generated collection, it might be a good idea.

kltm commented 3 years ago

@goodb History and conclusion here: https://github.com/geneontology/minerva/issues/85 I believe that the data can be cleansed.

goodb commented 3 years ago

Looks like @balhoff already tried a cleanse. Wonder why they are still in there? Anyway, easy to get rid of them.

vanaukenk commented 3 years ago

@goodb @kltm

Can we close this ticket?