search

geneontology / go-shapes

Schema for Gene Ontology Causal Activity Models defined using RDF Shapes
2 stars 0 forks source link

WIP: Changes to date field #263

Closed vanaukenk closed 2 years ago

vanaukenk commented 3 years ago

From 2021-07-06 MOD imports call here are the proposed modifications to date field to make explicit that 'date' refers to modification date:

1) Change field label from 'date' to 'modification_date'. 2) Update PREFIX to change 'date' to 'modification_date' and refer to DC term 'modified'. 3) Make cardinality for this field uniformly {1}

Note that we are not changing xsd:string as this field is currently in use and we'll need to consider the consequences of changing to either xsd:date or xsd:dateTime. The proposed changes here should also not affect the current MOD imports.

kltm commented 3 years ago

Not considering the tests for the moment, I believe that this would be a change without much consequence except being able to process import models with history--nothing should effect clients or downstream.

kltm commented 3 years ago

That said, @balhoff as there is an update to the URI here, wouldn't that mean that we have to do a bulk model upgrade if we took this?

balhoff commented 2 years ago

That said, @balhoff as there is an update to the URI here, wouldn't that mean that we have to do a bulk model upgrade if we took this?

@kltm you're right; I had meant to suggest just changing the prefix name to modification_date (just to go ahead and solidify our interpretation), but not changing the URI yet.

vanaukenk commented 2 years ago

I restored the date URL to its original (currently in ShEx).

We can update to the modified URL at a later date.

@kltm please let me know if it's okay to go ahead and merge. Thx.

kltm commented 2 years ago

@vanaukenk @balhoff I believe that this now correctly reflects our discussion.

vanaukenk commented 2 years ago

Thank you @kltm @balhoff