search

geneontology / go-shapes

Schema for Gene Ontology Causal Activity Models defined using RDF Shapes
2 stars 0 forks source link

WIP: Adding creation_date and import_date fields #264

Closed vanaukenk closed 2 years ago

vanaukenk commented 3 years ago

From 2021-07-06 MOD imports call, adding creation_date and import_date fields to capture additional metadata about when annotations were created at an external resource and the date on which the annotation was imported into Noctua.

Specifically: 1) Add PREFIX creation_date and refer to DC term 'created' 2) Add PREFIX import_date and refer to DC term 'dateAccepted' 3) Add these two new fields to both GoCamModel and ProvenanceAnnotated shapes 4) Make cardinality for these two field uniformly {0,1}

Note that these changes will allow us to model additional date information wrt the MOD imports, but otherwise should not affect the current workflows.

kltm commented 3 years ago

Not considering the tests for the moment, I believe that this would be a change without much consequence except being able to process import models with history--nothing should effect clients or downstream.

kltm commented 3 years ago

Talking to @cmungall a little, it may be worth reconsidering having xsd:string here instead of xsd:dateTime. Reasoning for that includes more flexibility (ISO8601 is larger and includes simply formatted dates), uniformity, being more inline with current software, and possibly being easier to work with in future software (e.g. a different data store).
Suggestions for shoring up what we have with xsd:string could be: adding additional documentation to the xsd:string explaining its use as ISO8601 and adding a regexp to the shex to ensure conformance w/ISO8601.