geneontology / go-shapes

Schema for Gene Ontology Causal Activity Models defined using RDF Shapes
2 stars 0 forks source link

Include 'contributes to' in ShEx? #269

Closed vanaukenk closed 2 years ago

vanaukenk commented 2 years ago

Curators would like to make standard annotation statements in Noctua such as Gene X 'contributes to' MF.

We haven't yet modeled this statement in the ShEx, probably because we were thinking that those standard 'contributes to' annotations to genes would be output from the alternative Noctua statement: Protein-Containing Complex X enables MF where each individual member of the Protein-Containing Complex is captured with a 'has part' relation.

We get ShEx violations in both the gene-centric imports and new standard annotations when these statements exist.

I'd propose that, for now, we add a shape for 'contributes to' to the ShEx but also discuss this in light of overall GO-CAM strategy and annotation guidelines.

Note, too, that there is an annotation check in Protein2GO that genes annotated to an MF using 'contributes to' must also be annotated to GO:0032991, protein-containing child, or a child term. Currently this is only a proposed go rule: https://github.com/geneontology/go-site/tree/master/metadata/rules#gorule0000049

vanaukenk commented 2 years ago

Added: https://github.com/geneontology/go-shapes/pull/271