geneontology / go-shapes

Schema for Gene Ontology Causal Activity Models defined using RDF Shapes
2 stars 0 forks source link

Can MFs be 'part of' other MFs? #52

Closed vanaukenk closed 3 years ago

vanaukenk commented 5 years ago

Looking at annotation extensions for MF annotations, curators have made 'part of' relations between MFs. These annotations have also been made in GO-CAM models.

Do we want to allow this?

If so, we need to add it to the ShEx specs.

balhoff commented 5 years ago

@vanaukenk did this come up in the call yesterday? I can't remember.

vanaukenk commented 5 years ago

No, we didn't discuss this on yesterday's call.

@thomaspd @pgaudet What do we want to do wrt annotating sub-functions in GO-CAM models?

ukemi commented 5 years ago

For compound functions, this will be required won't it?

vanaukenk commented 5 years ago

@ukemi - I would think so, yes.

We could have one 'main function' and then have 'has part' relations from that to the sub-functions.

ukemi commented 5 years ago

But at the instance-level has_part and part_of are inverse properties.

vanaukenk commented 5 years ago

Further discussion with @balhoff and @ukemi

Adding a 'has part' @\ *;

should suffice to capture sub-functions, if we want to do that from a curation pov.

vanaukenk commented 5 years ago

A related issue for this is whether or not we want to annotate where sub-functions occur in GO-CAM models, e.g. ligand binding 'occurs in' extracellular region'.

ukemi commented 5 years ago

We should explore this. It might solve some spatial issues that have crept up recently.

balhoff commented 5 years ago

@vanaukenk:

Adding a 'has part' @<MolecularEntity> *;

I think you meant MolecularFunction?

vanaukenk commented 5 years ago

@balhoff - Yes, I've updated the original comment. Thx.

pgaudet commented 5 years ago

@thomaspd @cmungall : Yes

vanaukenk commented 3 years ago

ShEx still needs to be updated here.