geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.
http://geneontology.org
BSD 3-Clause "New" or "Revised" License
45 stars 89 forks source link

Change metadata to improve text on annotation downloads page #1018

Closed kltm closed 1 week ago

kltm commented 5 years ago

Currently, a products download page is produced directly from the pipeline and left places like: http://snapshot.geneontology.org/products/pages/downloads.html Some of the text is hard to read for intended audience.

Started by @pgaudet , see: https://github.com/geneontology/go-site/pull/1012 https://github.com/geneontology/go-site/pull/1011

kltm commented 5 years ago

Assuming submitter should match shorthand in groups.yaml I'm surprised that entity_type is uncontrolled. According to @dougli1sqrd none of these are currently used internally, so having them be labels would not be a problem. @cmungall would you know if these fields are used by others?

cmungall commented 5 years ago

I decree we should use biolink model types for entity type.

E.g. https://w3id.org/biolink/vocab/ProteinIsoform

Just use the fragment, e.g. ProteinIsoform. When we get around to adding a json-ld context we will can make the base for the type field be https://w3id.org/biolink/vocab/

Re isoforms, see https://github.com/biolink/biolink-model/issues/230

suzialeksander commented 1 year ago

OK, looks like i just made some changes for https://github.com/geneontology/go-site/issues/847 to change a blank entity type to 'protein', which is an existing type- I think this is an allowed entry?

For the other downloads, the entities they include are:

@pgaudet what do we want to label these as?

pgaudet commented 1 year ago

@suzialeksander Let's talk about his tomorrow?

pgaudet commented 1 year ago

Decision is to remove this column completely. The goal is to provide species-specific files containing all types of entities.

suzialeksander commented 1 week ago

entity type and submitter are not columns in the New Downloads Table.