geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.
http://geneontology.org
BSD 3-Clause "New" or "Revised" License
46 stars 89 forks source link

Update metadata for TAMU projects #1078

Closed jimhu-tamu closed 2 years ago

jimhu-tamu commented 5 years ago

A variety of files need to be updated and maintained for projects associated with the TAMU groups (@jimhu-tamu and @dsiegele). Following an email discussion with @vanaukenk and @kltm about whether we could do this directly via branching and pull requests is was suggested that I look at related documentation on

http://wiki.geneontology.org/index.php/Installing_and_Using_git http://wiki.geneontology.org/index.php/Ontology_Editors_Daily_Workflow

Based those, I am creating this Issue created to have a tracker id number for following the branch naming convention.

jimhu-tamu commented 5 years ago

As I suspected, I can branch on my local machine, but cannot commit a new branch to go-site

git push --set-upstream origin issue-1078
ERROR: Permission to geneontology/go-site.git denied to jimhu-tamu.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
kltm commented 5 years ago

For the time being, you can also fork and then create a PR back to us from your fork. I'll take a look at the setting for tomorrow to make this all easier.

jimhu-tamu commented 5 years ago

Created a pull request to test working from a fork. Doing it via the forked copy long-term is OK with me, assuming it works.

kltm commented 5 years ago

More documentation now here:

https://github.com/geneontology/go-site/blob/master/documentation/how-do-i-edit-metadata.md

via https://github.com/geneontology/go-site/commit/8fb6640a0f4c2d74db42a5df0ad3dbc79c591bb2

kltm commented 5 years ago

Is there any other metadata that you need changed?

jimhu-tamu commented 5 years ago

Yes, I did a minimal change to test the workflow.

The biggest thing is probably to manage where we will provide our post-svn gpad files (as we retire making gaf) and the stuff we used to email directly to Tony.

kltm commented 5 years ago

@jimhu-tamu For the data stuff, the metadata in question for you would be located at: https://github.com/geneontology/go-site/blob/master/metadata/datasets/gonuts.yaml https://github.com/geneontology/go-site/blob/master/metadata/datasets/ecocyc.yaml

We currently have GAF pickup (GPAD not quite there yet) and GPI pickup for loading into NEO (optional). If you need help setting up a place to drop files, please let us know.

jimhu-tamu commented 5 years ago

I was just going to provide a url to a directory on our server.

But does that mean we should still make gaf for now?

kltm commented 5 years ago

@jimhu-tamu Yes, all we'd need is a URL for a GAF on a web-accessible server. GAFs for the time being--the finalization of GPAD 2.0 is being worked out as we type, but GAF will still work as currency until there are more announcements.

jimhu-tamu commented 5 years ago

@kltm: I just attempted to submit a pull for new metadata to give the location of a pickup for the gene_association.ecocyc.gz on our server.

I need to do the same for a gpad 1.1 for the CACAO annotations. Can I get some help with how to compose that?

kltm commented 5 years ago

@jimhu-tamu If you're talking about https://github.com/geneontology/go-site/pull/1109, it doesn't seem to contain anything except a breaking adjustment to users.yaml (as of this writing).

For ecocyc, I would assume that the adjustment that would be needed would be to the file/line here: https://github.com/geneontology/go-site/blob/master/metadata/datasets/ecocyc.yaml#L19

For CACAO, I'm actually not sure. Is that the same thing (historically) as the GONUTS annotations? If so, the change would be here: https://github.com/geneontology/go-site/blob/master/metadata/datasets/gonuts.yaml#L19 . If not, a new file just like that named cacao.yaml in that directory would be the preferred way forward.

jimhu-tamu commented 5 years ago

The pull request should have only changed the source url in ecocyc.yaml. I modeled it on what I saw in the sgd.yaml

The place to fetch the gaf is

https://ecocyc.org/gaf/gene_association.ecocyc.gz

For CACAO, it's not the same as the gonuts annotations, which really should be obsoleted. Historically @suzialeksander would make the gpad and we would mail it to Tony Sawford. I emailed goa with the link for the downloadable copy, which is in gpad 1.1 (because we were using gpad and the gpad pickup doesn't seem to be ready). The link for that one is

https://gowiki.tamu.edu/gpad/CACAO.gpad.gz

kltm commented 5 years ago

@jimhu-tamu The only pull request that I see that you have open seems to have only a single breaking change in the YAML spacing: https://github.com/geneontology/go-site/pull/1109/files

We can go ahead and make the changes necessary at our end if you want.

@cmungall @vanaukenk Are we good to go ahead and have a CACAO source?

jimhu-tamu commented 4 years ago

The pull request should have only changed the source url in ecocyc.yaml. I modeled it on what I saw in the sgd.yaml

The place to fetch the gaf is

https://ecocyc.org/gaf/gene_association.ecocyc.gz

For CACAO, it's not the same as the gonuts annotations, which really should be obsoleted. Historically @suzialeksander would make the gpad and we would mail it to Tony Sawford. I emailed goa with the link for the downloadable copy, which is in gpad 1.1 (because we were using gpad and the gpad pickup doesn't seem to be ready). The link for that one is

https://gowiki.tamu.edu/gpad/CACAO.gpad.gz

There was an error in the URL for the ecocyc gaf. Should be:

https://ecoliwiki.org/gaf/gene_association.ecocyc.gz

vanaukenk commented 4 years ago

We discussed the fate of the gonuts.yaml entry and it will be removed from the datasets.

kltm commented 4 years ago

ecocyc is clear; now need to:

kltm commented 4 years ago

PR for gonuts removal opened.

pgaudet commented 2 years ago

@kltm I think this is done? I think we not get CACAO from GOA.

kltm commented 2 years ago

Stale either way, so I'm okay with closing.