YAML schema checks always pass no matter what (and bad metadata got in)

geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.

http://geneontology.org

BSD 3-Clause "New" or "Revised" License

45 stars 89 forks source link

YAML schema checks always pass no matter what (and bad metadata got in) #1983

Closed kltm closed 1 year ago

kltm commented 1 year ago

Looking into fixes around #1943 , I discovered that for some time the schema validation for YAML pass even when "INVALID" entries are found. Apparently, in the switch over to GHA from Travis, these were not properly check for the fail state. And I had though we had been so good!

kltm commented 1 year ago

I think I got it going again.

kltm commented 1 year ago

@pgaudet @suzialeksander We've apparently been running for a while without schema checks on the metadata. I've put in a fix and repaired anything I found so that we're passing and clean again. (The one bad ID for a noctua user wasn't used yet in any models, so safe there). Let me know if you see anything odd.