search

geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.
http://geneontology.org
BSD 3-Clause "New" or "Revised" License
46 stars 89 forks source link

gorule-0000013 not filtering out IEA annotations #2224

Open pgaudet opened 8 months ago

pgaudet commented 8 months ago

GORULE:0000013 states:

Experimental annotations (1) failing the taxon constraints are reported in the error reports but unchanged; non-experimental annotations (2) are filtered out of the pipeline products.

(1) EXP evidence codes: EXP, IDA, IEP, IGC, IGI, IMP, IPI, HDA, HEP, HGI, HMP, HTP.

(2) non EXP annotations: IBA, IKR, IRD, IC, ISA, ISM, ISO, ISS, NAS, RCA, TAS, IEA.

However we have IEA annotations to GO:0030313 cell envelope that has a taxon restriction only in bacteria that are passing, see https://github.com/geneontology/go-annotation/issues/1636

DEHA2C08096g Gram-negative-bacterium-type cell wall

should be filtered.

@balhoff is this your code?

Thanks, Pascale

kltm commented 8 months ago

@pgaudet I'd note that @dustine32 also has a hand in the late taxon constraint filter stage.