geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.
http://geneontology.org
BSD 3-Clause "New" or "Revised" License
43 stars 89 forks source link

GO procedure for if/when OMIM CURIE/identifier changes to "MIM" #2238

Open kltm opened 6 months ago

kltm commented 6 months ago

I've been asked to provide feedback on OMIM changing its CURIEs to "MIM".

Looking at the primary GO upstream data (GAFs and GPADs), there does not appear to be any OMIM data that would need to be cleansed. I.e. reset && zgrep -i 'omim:' *-src.*.gz returns nothing.

Looking at our own curation store (GO-CAMs), there is a single reference in a single model (http://noctua.geneontology.org/editor/graph/gomodel:55caf38600000003), which is an "experimental" model, unpublished, and almost a decade old. I.e. reset && grep -i 'omim:' *.ttl returns one thing.

Looking at our metadata, we have OMIM listed, but that could likely just be updated (https://github.com/geneontology/go-site/blob/f12f4d0988a91a6d6e636964de65a36e603d857f/metadata/db-xrefs.yaml#L1765).

Overall, I do not believe there would be any noticeable effect on the GO.

kltm commented 6 months ago

I don't believe we have any real reason to care one way or another about this. Tagging @cmungall and @pgaudet .

balhoff commented 6 months ago

There seem to be 4 definition xrefs in the ontology using OMIM:.

kltm commented 6 months ago

@balhoff Ah, that's worth keeping an eye on. (I'm not sure why I blanked on the ontology when grepping...) Still, a relatively easy "fix" with little propagation, right?

kltm commented 6 months ago

Changing the issue slightly as there should be some action if/when this goes forward.

kltm commented 6 months ago

@sierra-moxon Is there an upstream issue to watch here?

balhoff commented 6 months ago

@balhoff Ah, that's worth keeping an eye on. (I'm not sure why I blanked on the ontology when grepping...) Still, a relatively easy "fix" with little propagation, right?

Very easy update.

sierra-moxon commented 6 months ago

At the moment, bioregistry requires the prefix to be "omim" -- the discussion to change that in bioregistry is here: https://github.com/biopragmatics/bioregistry/issues/497

In other groups trying to be compliant with bioregistry prefix declarations, waiting until it changes in bioregistry is important. But, from the generators of the identifiers and owners of that namespace, they do seem to make it clear that want MIM to be the prefix.

cmungall commented 6 months ago

The ontology xrefs should be easy to fix and of course we'd keep OMIM as a synonym.

IMO OMIMs would be a good source of IMPs especially for biochemical phenotypes but looks like we get most of this in human via IEA anyway

pgaudet commented 6 months ago

OK for me either way.

pgaudet commented 6 months ago

@cmungall Should we delete this model? http://noctua.geneontology.org/editor/graph/gomodel:55caf38600000003 ? (created by you)