geneontology / go-site

A collection of metadata, tools, and files associated with the Gene Ontology public web presence.
http://geneontology.org
BSD 3-Clause "New" or "Revised" License
46 stars 89 forks source link

Check current GO rules against previous implementation #712

Closed kltm closed 6 years ago

kltm commented 6 years ago

Looking at the "Mike" script, there are some rules that may be useful that are not currently implemented.

http://geneontology.org/page/annotation-quality-control http://geneontology.org/page/annotation-quality-control-checks

Go through the latter and see what can be salvaged. This ticket is to be closed once the above has been reviewed.

pgaudet commented 6 years ago

http://geneontology.org/page/annotation-quality-control-checks

Implemented

Approved

Proposed

pgaudet commented 6 years ago

@vanaukenk @ukemi We should review these on Wed to make sure they are still what we want.

ukemi commented 6 years ago

I suggest we triage: ones we certainly want to keep, ones we want to certainly discard and ones we want to reconsider based on GO-CAM modeling.

vanaukenk commented 6 years ago

Yes, let's discuss on Wednesday. I think we should keep GO-CAM models in mind for reviewing most all of them, actually, and if needed, create a model to check and/or illustrate the implementation.

dougli1sqrd commented 6 years ago

Has this been appropriately reviewed?

So says @kltm

Go through the latter and see what can be salvaged. This ticket is to be closed once the above has been reviewed.

dougli1sqrd commented 6 years ago

Maybe we should merge this with #670; @pgaudet can you make sure there is no missing information?

pgaudet commented 6 years ago

We have everything in #670.

Thanks!