Closed dustine32 closed 3 years ago
@dustine32 I'm not sure if we discussed this elsewhere, but date and contributor must exist on all individuals and at the model level.
@kltm Thanks for clarifying this! I will update in the code.
@dustine32 Actually, have you tried the ShEx on these yet? I would hope that they would have failed for this reason; if not, that's another thing to worry about...
This looks to be working stably in all of the new models.
I looked at where I'm adding the date and contributor in the OWL and it's actually only going on the evidence individual and Axiom. For example:
(The evidence individual started getting these fields in response to https://github.com/geneontology/gocamgen/issues/15)
Meanwhile, the GP and term individuals aren't currently getting any contributor or date. Should I start doing this? This might get cluttered when "collapsing" (translating) multiple GPAD lines to single annotation individuals, like what is currently happening to cause the multiple dates seen here:
Tagging @kltm @ukemi @vanaukenk. We can close if no action is needed.