geneontology / minerva

BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

Add cli option to allow running checks against a graphstore journal. #542

Closed balhoff closed 6 months ago

balhoff commented 6 months ago

New CLI option --check-graph-type. Fixes #541.

kltm commented 6 months ago

Noticing that tests did not pass?

balhoff commented 6 months ago

I will look at the tests—they are unfortunately sensitive to changing external data.

balhoff commented 6 months ago

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

I just want to confirm that the -> operator is Java 8?

                    if (gocam.getAnnotations().stream().noneMatch(annotation ->
                            annotation.getProperty().getIRI().equals(graphType)

Java 8!

balhoff commented 6 months ago

Test failure relates to website problems at biopax.org. Fix at #543.

balhoff commented 6 months ago

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

@kltm one thing to note—don't use this flag if testing the actual Minerva database. The models there don't have this annotation, which is inserted by the graphstore build.

kltm commented 6 months ago

Adds a default "off" flag that will bypass certain problematic models--from the POV of QC; if "on", it will skip anything that doesn't have the appropriate data.

@kltm one thing to note—don't use this flag if testing the actual Minerva database. The models there don't have this annotation, which is inserted by the graphstore build.

@balhoff Not that I was planning on changing the flags for our production Noctua stuff, but wouldn't that check be safe when looking at just a "TTL models only" store?

balhoff commented 6 months ago

@kltm in a TTL models only store, all of them would get skipped if you use that flag. They won't contain the triple ?ont :graphType :noctuaCam.

kltm commented 6 months ago

@balhoff Ah, I think I understand: the trick is that they are marked in the "extended" store, but not so in the "noctua" one, and you're using that as the criteria?

balhoff commented 6 months ago

Yes.