geneontology / minerva

BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

Revisit noctua model loading for amigo #80

Closed kltm closed 7 years ago

kltm commented 7 years ago

In owltools, in ./OWLTools-Runner/src/main/java/owltools/cli/SolrCommandRunner.java, there is currently a filter in there (isAlphanumeric) that was causing no noctua-models to be picked up, and crashing some loads in their later phases.

        @CLIMethod("--read-model-folder")
        public void processModelFolder(Opts opts) throws Exception {
                legoFiles = new ArrayList<File>();
                String modelFolderString = opts.nextOpt();
                File modelFolder = new File(modelFolderString).getCanonicalFile();
                File[] modelFiles = modelFolder.listFiles(new FilenameFilter() {

                        @Override
                        public boolean accept(File dir, String name) {
                                return StringUtils.isAlphanumeric(name);
                        }
                });
                Arrays.sort(modelFiles);
                for (File modelFile : modelFiles) {
                        LOG.info("Using file for Lego: " + modelFile);
                        legoFiles.add(modelFile);
                }
        }

Now, we don't really use the metadata or noctua-models in AmiGO right now, except as a proof of concept, so it's not a huge loss/priority. However, it might be a good time to visit what we want to do with AmiGO loading and browsing now that graph stores are available. There was certainly a lot that we wanted to do, that we never got aroung to with the first hack job.

Or, we could just add a .ttl glob there instead and continue on for a while longer. Any thoughts @cmungall ?

kltm commented 7 years ago

By the way, in case we need to re-enable those loads for some reason we forgot, I pulled the noctua-model load sections from https://build.berkeleybop.org/view/GOlr/job/load-golr-tomodachi/ https://build.berkeleybop.org/view/GOlr/job/load-golr-noctua-neo/

cmungall commented 7 years ago

Ah, we already fixed this lurking assumption for the lego-to-gpad conversion

https://github.com/geneontology/minerva/commit/ebbe2937735a80dc7744e6cb516c5262755642e1

kltm commented 7 years ago

Reopen until tested.

kltm commented 7 years ago

Looking good so far--product is coming through.