geneontology / neo

noctua entity ontology
9 stars 2 forks source link

Add FB Developmental and Anatomy Ontology #117

Closed hattrill closed 11 months ago

hattrill commented 1 year ago

Adding this here (not sure if it is better on Neo tracker?)

Please add two fly ontologies to NEO:

FlyBase Developmental Ontology (FBdv, http://obofoundry.org/ontology/fbdv) Latest version: http://purl.obolibrary.org/obo/fbdv.owl

and

FlyBase Anatomy Ontology (FBbt; http://obofoundry.org/ontology/fbbt) Latest version: http://purl.obolibrary.org/obo/fbbt.owl

kltm commented 1 year ago

@hattrill Just confirming, but this is so that these terms are available in the autocomplete(s), correct?

hattrill commented 1 year ago

@kltm Yes and I assume that you don't want/allow random ontology terms to be dropped into the extension field.

kltm commented 1 year ago

@balhoff I guess the two things to do here are to either just add them separately to the GOlr load (https://github.com/geneontology/pipeline/pull/344) or to add them to go-lego.owl. Any thoughts one way or another?

balhoff commented 1 year ago

I think we should add to go-lego/go-amigo; otherwise we could run into the problems we had before with the reasoner and direct loading into AmiGO.

kltm commented 1 year ago

@balhoff Hm. How many terms are we talking about here? I'd be guessing, looking at the non-GO ontologies we already load (https://amigo.geneontology.org/amigo/search/ontology), that it would be unlikely to make a huge change. If so, could you close the PR out in favor of changes to the ontology build (and link that here)?

balhoff commented 12 months ago

Pull request over here: https://github.com/geneontology/go-ontology/pull/26523.

kltm commented 12 months ago

We don't quite have a state for this, but I would expect this to propagate out by the next release or so.

vanaukenk commented 11 months ago

@kltm @balhoff

Just double-checking about this work before tomorrow's maintenance outage. Will this require a successful snapshot release to percolate to production Noctua?

balhoff commented 11 months ago

Luckily I see FBbt in yesterday's successful snapshot. :-)

vanaukenk commented 11 months ago

Checking this after the 2023-12-14 Noctua maintenance outage, it looks like the FBbt and FBdev terms are now available in Noctua.

@hattrill - if you want to also double-check to make sure everything is working as expected wrt those ontologies, that'd be great, and then we can close this ticket.

Thx.

hattrill commented 11 months ago

All seems good to me wrt ontologies. So I will close this.

@vanaukenk Might need a bit of help with interface, but we can go over this in training after Christmas.

Thanks

pgaudet commented 9 months ago

For extensions in P2GO, we need the following mappings to be present in GO-upper:

[Term] id: FBbt:00007002 is_a: GO:0005623 ! cell

[Term] id: FBbt:10000000 is_a: UBERON:0001062 ! anatomical entity

[Term] id: FBdv:00007012 is_a: UBERON:0000105 ! life cycle stage

PR is here: https://github.com/geneontology/go-ontology/pull/26997

pgaudet commented 7 months ago

Added database: FBdv to dbxref.yaml file

database: FBdv name: Drosophila development rdf_uriprefix: http://purl.obolibrary.org/obo/FBdv generic_urls:

PR is here: https://github.com/geneontology/go-site/pull/2292

kltm commented 7 months ago

Since closing, there have been two more PRs. Is this now completed?