search

geneontology / neo

noctua entity ontology
9 stars 2 forks source link

Create an is-a closure version of NEO for Noctua autocomplete #48

Closed vanaukenk closed 5 years ago

vanaukenk commented 5 years ago

For the ontology autocomplete fields in Noctua it would be good to just use is-a closure. This would prevent potential confusion about what terms show up in the autocomplete menu and also possible annotation errors.

An example is what currently happens when typing in 'mechano' in the BP field of the form:

image

MF terms are also returned in this search due to the 'part of' relation between some MF and BP terms in the ontology.

See also: https://github.com/geneontology/noctua-form/issues/34 https://github.com/geneontology/noctua-form/issues/19

cmungall commented 5 years ago

This is actually in the solr loading and nothing to do in the solr loader

We actually have a slot in solr for the is-a closure:

https://github.com/geneontology/amigo/blob/99cfac2a8554c0d88fe675c7f0065c04a203ff6a/metadata/ont-config.yaml#L125-L131

And this is being loaded:

https://github.com/geneontology/noctua-form/issues/19#issuecomment-553198688

So I think this issue can be closed?

kltm commented 5 years ago

Indeed.