NEO GOlr / Solr load does not use "modern" loader, so does not build all closures for "modern" AmiGO

[kltm]

Without the following (misleading, but that's not really what AmiGO is there for) changes, the term pages on http://noctua-amigo.berkeleybop.org fail with a ChewableGraph error. E.g. 500 on http://noctua-amigo.berkeleybop.org/amigo/term/GO:0065009

This is because the recently new AmiGO software expects to be able to find the proper closure for the default closure, but it is not there for NEO as it is using an older loader docker image.

In the meantime, just to make sure it's chugging along, the following changes have been made to the live system:

git diff

diff --git a/perl/lib/AmiGO/WebApp/HTMLClient.pm b/perl/lib/AmiGO/WebApp/HTMLClient.pm
index 675f7be..26447b3 100644
--- a/perl/lib/AmiGO/WebApp/HTMLClient.pm
+++ b/perl/lib/AmiGO/WebApp/HTMLClient.pm
@@ -1425,7 +1425,8 @@ sub mode_term_details {
   ## using. Default the default to 'isa_partof'.
   $params->{relation} = $self->param('relation')
     if ! $params->{relation} && $self->param('relation');
-  my $default_relation = $params->{relation} || 'isa_partof';
+  #my $default_relation = $params->{relation} || 'isa_partof';
+  my $default_relation = $params->{relation} || 'regulates';
   $self->set_template_parameter('DEFAULT_RELATION', $default_relation);

   ## Optional RESTmark input for embedded search_pane--external
diff --git a/perl/lib/AmiGO/Worker/GOlr/Term.pm b/perl/lib/AmiGO/Worker/GOlr/Term.pm
index a777d8a..50dac86 100644
--- a/perl/lib/AmiGO/Worker/GOlr/Term.pm
+++ b/perl/lib/AmiGO/Worker/GOlr/Term.pm
@@ -27,8 +27,8 @@ sub new {

   ## Default closure relation. Starting setup to deal with
   ## future of #620.
-  #my $default_closure_relation_set = 'regulates';
-  my $default_closure_relation_set = 'isa_partof';
+  my $default_closure_relation_set = 'regulates';
+  #my $default_closure_relation_set = 'isa_partof';

   #$self->kvetch('searcher: ' . $self->{AEJS_GOLR_DOC});

Fixing this would be either getting an improved loader through there, getting a new loader for the same interface, or lowering expectations.