geneontology / noctua-alliance-pathway-preview

0 stars 0 forks source link

APP seems to be broken on certain models in Dev #11

Open suzialeksander opened 1 year ago

suzialeksander commented 1 year ago

@dustine32 and I can't get http://noctua-dev.berkeleybop.org/workbench/noctua-alliance-pathway-preview/?model_id=gomodel%3AYeastPathways_PWY3O-402 to load, pathways are only in Dev so can't test on production. Other models load for us in dev though, like http://noctua-dev.berkeleybop.org/workbench/noctua-alliance-pathway-preview/?model_id=gomodel%3AYeastPathways_THRESYN-PWY successfully loads. Screenshot 2023-07-28 at 15 43 05

dustine32 commented 1 year ago

@suzialeksander This ended up being due to bad data in the model, which I need to fix. Some individuals don't have type/class info and this causes the viewer to choke when attempting to extract its label. @tmushayahama already pushed a fix to the viewer so that you can at least view the model on noctua-dev now.

tmushayahama commented 1 year ago

@suzialeksander on another topic, the model preview doesn't really look nice visually on larger horizontal models. I think mostly it is because the lines are thick and no space margins between boxes As compared to visual pathway editor's preview mode below Question: is it okay as it is now, or preferably you would like a more readable view (sacrificing compactness)

image .

suzialeksander commented 1 year ago

@tmushayahama I'd say it's ok as it is now, because we need you on other stuff that's functional instead of just visual.