geneontology / noctua-annotation-review

0 stars 0 forks source link

Proper handling of With column #38

Open lpalbou opened 3 years ago

lpalbou commented 3 years ago

The bulk search & replace mode of ART currently requires / restrict the search and the replace to terms / entities that can be resolved by GOLr. In other terms, one can NOT search or bulk replace a value in the With column as it's free text.

In the following example, if one was to search for "PMID:1234", ART would only detect the occurence in the "Reference" column, not in the "With" column. Consequently, a bulk replace of "PMID:1234" by "PMID:X" would only change the value in "Reference" but not in "With":

Screen Shot 2021-04-12 at 2 01 42 PM

The same applies for any value in With field, including GPs. And this can be counter intuitive and create mistakes/inconsistencies during the bulk editing models.

To discuss: what should be the proper handling of the "With" column with respect to search & bulk replace @ukemi @vanaukenk

vanaukenk commented 3 years ago

@lpalbou

For v1 of ART, changes to the With/From field are not in scope, but we should make that very clear to curators when they are testing and/or using ART so there are no misunderstandings.

There are a number of wider issues that need to be addressed wrt Noctua and the With/From field that would make a great future sprint.

As an aside, I can't think of a case where a curator would put a PMID in the With/From field, but they would certainly put something like a GO term (e.g. for an IC annotation), so that would be a good future test of updating the With/From field. I've made such a test model on noctua-dev.

Thx.