geneontology / noctua-annotation-review

0 stars 0 forks source link

Clear button in search box not working #4

Closed vanaukenk closed 2 years ago

vanaukenk commented 5 years ago

The Clear button in the search box does not seem to be working to clear any value.

It just seems to restore the generic label, e.g. Go Term, when the field is empty.

vanaukenk commented 5 years ago

@tmushayahama - revisiting this ticket.

The clear button closes the search box, but doesn't seem to clear the values. It would be better if 'Clear' just cleared the inputs in the search box(es) and left the search window open.

Thx.

vanaukenk commented 5 years ago

Ideally, it would be possible to either clear all or clear one or more input boxes individually.

vanaukenk commented 5 years ago

@tmushayahama I'm trying to test this, but it seems that now after I've selected a search term and click on 'Search' the search term is cleared from the box, so I can no longer see what I'm searching on and then test if clicking on 'Clear' removes it from the box. Clicking on 'Clear' does still keep the search widget open, though, so that is now working as expected.

tmushayahama commented 5 years ago

@vanaukenk I realized that I had put the clear functionality after search button is clicked. Now I see the problem of editing a box after search. I will remove the clear after search. The other part is the filter drawer/panel idea was to serve it as a search summary as well and the search panel for new input only. Should I add search summary as well on the search drawer? Where do you think?

Filter Panel/Drawer image

vanaukenk commented 5 years ago

@tmushayahama Yes, I think a search summary would be really helpful to curators. Can we fit it across the top of the table where the 'Filtered by' text currently is?

vanaukenk commented 5 years ago

@tmushayahama For clearing the filter boxes, it looks like clicking on the 'x' clears the selected value, but not the original text I typed in. Can clicking on the 'x' clear the entire box? Otherwise, the curators will need to additionally remove their typing.

I see the same thing when I clikc on the 'Clear' button at the bottom of the list of filters.

Thx.

image

image

pgaudet commented 2 years ago

This seems to work for me

Ca we close @vanaukenk ?

vanaukenk commented 2 years ago

This one is done.