geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

SAE needs to allow EMAPA IDs #37

Closed krchristie closed 6 years ago

krchristie commented 6 years ago

Although the SAE allows me to autocomplete EMAPA IDs for mouse anatomy terms (as you can see in attached picture), it then shows them with an error, saying it is expecting an Uberon ID instead.

20180310-ccextsbyautocomplete

Here's the model: http://68.181.125.145:8910/workbench/simple-annoton-editor/?model_id=gomodel:5a98684700000052

thomaspd commented 6 years ago

This looks like the same basic issue as #32 . @cmungall can you also address this one? @tmushayahama, for both of these when you are reading the graph to populate the SAE form and check validity, you'll need to recognize additional prefixes (EMAPA and WBbt) as valid anatomy terms, just like UBERON.

cmungall commented 6 years ago

These two are different. #32 is dependent on me merging in the uberon-to-wbbt bridge, which will done after validation.

We already have uberon-bridge-to-emapa.owl merged in, which means that mapped EMAPA classes will show up as subclasses of uberon anatomical entity. I confirmed this:

http://noctua-golr.berkeleybop.org/select?q=bronchus&defType=edismax&qt=standard&indent=on&wt=json&rows=10&start=0&facet=true&facet.mincount=1&fq=document_category:%22ontology_class%22&fq=isa_closure:%22UBERON:0001062%22&qf=annotation_class%5E3&qf=annotation_class_label_searchable%5E5.5&qf=synonym_searchable%5E1&fl=id,annotation_class_label,idspace

you can see this includes EMAPA bronchus (as well as Uberon. We need curator guidelines as to what to pick when, especially as we increasingly annotate outside our species).

It looks like @tmushayahama is implementing an addition constraint such that the ID is expected to be in the Uberon ID space. I generally discourage making any assumptions about IDs, for ontologies, or databases. Use the ontology to discover semantics.

tmushayahama commented 6 years ago

can you double check on this one.

krchristie commented 6 years ago

Well, it isn't throwing an error about an EMAPA term anymore, but this isn't working right either.

Here is what I entered:

ccfullentryformw-emapa

Here is what it saved:

savedfrom-ccfullentryformw-emapa

Note that the saved annoton failed to save the first CC term and then moved the cell type and anatomy terms up one blank in the annoton.

krchristie commented 6 years ago

Also, while the autocomplete on an EMAPA term works IF the correct term shows up, I could not get the term I wanted to show up in the autocomplete list.

I wanted the term "trachea" (EMAPA:16853), but when I used "trachea " (note presence of space after word), I got this: trachea-autocomplete

and when I used the ID, I got a larger selection of EMAPA choices, but NOT the one that matched the ID I put into the box: emapa-idautocomplete

In both of these, no additional options appear if you use the down arrow to go to the bottom of the list; you just end up on the top again.