geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Prevent users editing in SAE if the model contains edges that could potentially be lost #4

Closed cmungall closed 6 years ago

cmungall commented 7 years ago

the SAM only covers a subset of expressivity of GO-CAMs. If a model contains extra info, e.g. causal linkages, these can be lost if any edits are made in the SAM.

Minimally the SAM should say: be careful editing existing models

Ideally, the SAM would detect if the model contains any edges untranslatable to simple annotons and warn if these are present.

kltm commented 7 years ago

As well, it should be noted that when "editing" an annoton in this tool, currently it is destroyed and replaced. It is also possible to mine out the entities and replace them with new class expressions, but it would take a little more work. Doing so, however, would obviate the need to warn users as non-delete changes would no longer be destructive.