search

geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

inappropriate autofill behavior when switching from "BP only" to "DEFAULT" template #59

Closed krchristie closed 6 years ago

krchristie commented 6 years ago

I think this behavior when switching from the BPonly to the DEFAULT templates is not what we want.

Here I have filled in a BP only template: 20180425-fillinginbponly

If I then switch to the DEFAULT template, it autofills in the root MF with ND: 20180425-defaultafterbponly

We should never be automatically assuming the ND evidence code, so I think this is not the behavior we want.

tmushayahama commented 6 years ago

@krchristie @vanaukenk no longer copying/saving the added information when switching between bbOnly and default. It means that when you switch from default to bpOnly and back to default, all your form data (unsaved) will be gone. Will add a warning https://github.com/geneontology/simple-annoton-editor/issues/51

krchristie commented 6 years ago

Sorry so slow to check. Like Kimberly, I will find it helpful if you leave them open after tagging me to check them so that I still see them in the list of Open issues.

I am not sure if this is behaving the way you meant it to because I am not sure exactly what you mean by "no longer copying/saving the added information". Does this mean specifically that it is not saving the MF info that was added by the BP ONLY template, but it IS keeping the BP?

From the one text I just did, where I entered info into the BP ONLY template: 20180507-dataentryinbponly

and then switched to the DEFAULT template: 20180507-afterswitchingfrombponlytodefault

this looks OK to me.