geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

"more evidence" & "clone evidence" popups don't handle with info properly #62

Closed krchristie closed 6 years ago

krchristie commented 6 years ago
  1. I entered a BP annotation that included an allele ID: 20180426-1-enteringimpwallele

  2. I opened the More Evidence popup to enter a second line of evidence. Despite having entered an allele ID, it is displayed as blank in this popup: 20180426-2-enteringmoreev

  3. I entered a second line of mutant phenotype evidence with a different PMID & allele ID (without correcting the original line): 20180426-3-addmoreev-lost1stalleleid

  4. I went to enter a cell type and used the Clone Evidence popup. Note that it does not even have a place to display the with info, which is necessary since I could potentially have multiple different with fields using the same evidence code from the same paper, so it is very hard to select the correct evidence 20180426-4-cloneevneedsmoreinfo

This is even worse once I am entering a second annoton with different papers: 20180426-4b-cloneevneedsmoreinfo

  1. Having added evidence from the Clone Evidence popup (that did not display the With info), there is no With info in the DEFAULT entry form: 20180426-5-clonedevmissingalleleid

  2. Thus, when I save, most (Ift140 annoton) or all (Cbr1 annoton) of my annotations do not have the with field filled, though my intent was that they all should. It is not clear to me what I did differently between the two annotons that the with field was maintained in one place in the Ift140 annoton.: 20180426-6-tableviewshowingmissingalleleid

vanaukenk commented 6 years ago

@tmushayahama - this also seems to be fixed.
@krchristie - I am closing this issue now, but please re-open if something is not working as expected.