search

geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Clone evidence option should require evidence code and reference before populating list #64

Closed vanaukenk closed 6 years ago

vanaukenk commented 6 years ago

It is currently possible to enter an evidence code with no reference and have that option show up in the list of possible evidence to clone.

I found this out by entering an evidence code and then remembering that I could just clone the evidence.

Without removing the original evidence code, I went to the clone evidence list and now had two entries to choose from, one with the paper reference and one without. The entry without the paper should not be allowed on the list.

krchristie commented 6 years ago

I noticed this yesterday and agree that evidence lines shouldn't show up in the clone options unless they are complete. I did exactly the same thing Kimberly did, where I had entered an evidence code and then remembered I could clone instead.

vanaukenk commented 6 years ago

If the user opens the clone evidence window, whatever evidence exists on the line should be cleared.

krchristie commented 6 years ago

This looks good to me. Thanks @tmushayahama

vanaukenk commented 6 years ago

@tmushayahama - also closing this issue as it appears to be working correctly now. Thx.