geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

BP only form should require BP term before allowing curator to save #74

Open vanaukenk opened 6 years ago

vanaukenk commented 6 years ago

Currently, the BP only version of the form allows curators to save an annotation even if they've only input a gene product name.

The result is an annotation to the root node of MF with no supporting evidence.

The BP only form should require that curators also enter a BP term and evidence before they can save.

Thx.

vanaukenk commented 6 years ago

@tmushayahama

I've tested and this all looks good now.

Thx.

vanaukenk commented 5 years ago

Re-visiting this issue since it is possible for a curator to enter just 'PMID:' as a reference and still get the annotation to save.
The reference should have characters and/or numbers after the colon. Note that this reference behavior is not limited to BP only, but also happens on the Default form.

tmushayahama commented 5 years ago

@vanaukenk I missed this. Will handle it well in Form 2.0 . It will follow these rules (is below premises correct)