geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Copying and modifying an annotation doesn't allow me to save #79

Open vanaukenk opened 6 years ago

vanaukenk commented 6 years ago

I've copied an existing annotation from the table at the bottom of the form to the form, modified some of the entry (specifically changed the reference for MF and CC and removed the BP annotation) and even though the SAVE button is enabled, when I click on it, nothing seems to happen.

The copy functionality is a great feature to have for making small modifications to existing annotations, so it'd be nice to get this all working as expected.

Thx!

vanaukenk commented 5 years ago

@tmushayahama I can now save an annoton after copying it from the table to the form and modifying it.
However, the resulting behavior of the modified annotation wasn't what I expected in the graph editor. For example, if I copy an annotation, add more evidence to it, and then save, rather than folding the evidence into the one annotation, it created a new, separate annotation. This suggests that maybe we need to refine what happens to the annotations based on the action that curators actually perform.

vanaukenk commented 5 years ago

TODO: document behavior of this feature of the form.

tmushayahama commented 5 years ago

@vanaukenk see comment on here https://github.com/geneontology/simple-annoton-editor/issues/83 I should have put the comment here