search

geneontology / noctua-form-legacy

Simple annoton editor workbench for Noctua.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

The NOT qualifier does not seem to appear #95

Closed kltm closed 4 years ago

kltm commented 5 years ago

From @krchristie

1. In the form editor

The NOT qualifier does not seem to appear at all in the form view. There are two annotations to the term 'phasphatidylinositol-4,5-bisphosphate binding' in this model, one without a NOT and one WITH a NOT. However, in the form view you cannot tell the which one has the NOT qualifier. The one that is supposed to have it is the row highlighted in gray; compare to the top row.

20190530-noNOTinForm

Similarly to the Annotation Preview, it would be fine to place the qualifier right next to the 'enabled by' relationship. However, for readability in the curation interface, it would be preferable if it was displayed as rather than <enabled by|NOT> like it does in the Annotation preview.

krchristie commented 5 years ago

Looks like I left out a phrase in my comment above and I can't edit the above since it was done by @kltm instead of me.

Similarly to the Annotation Preview, it would be fine to place the qualifier right next to the 'enabled by' relationship. However, for readability in the curation interface, it would be preferable if it was displayed as something like "NOT enabled by" rather than <enabled by|NOT> like it does in the Annotation preview.

tmushayahama commented 5 years ago

@krchristie Yes, a little hiccup, I always forget that GP and MF are reversed. I will revise this, but is it ok if I just put it in the new Noctua Form

@vanaukenk @krchristie just to clarify. There is no NOT on the extensions?

vanaukenk commented 5 years ago

@tmushayahama

There is no NOT on the extensions?

That is correct; there is no NOT on the extensions. The only place the NOT value is used is to negate the GO term in the primary (i.e. unextended) annotation.