search

geneontology / noctua-form

2 stars 0 forks source link

Assigned_by blank in "Search Annotations" popup #147

Closed suzialeksander closed 1 year ago

suzialeksander commented 2 years ago

In Form, when the Search Annotations field has been selected, we would like to only import SGD annotations but the ASSIGNED BY field is blank: image

Don't think this is related to https://github.com/geneontology/noctua-form/issues/38, which looks solved??

vanaukenk commented 2 years ago

This looks to be working fine on noctua-dev.
I've checked several different genes, species, and annotations and can see assigned by for MODs, UniProt, InterPro, and GOC.

vanaukenk commented 2 years ago

This was tested again on noctua-dev with this model:

http://noctua-dev.berkeleybop.org/editor/graph/gomodel:6202e3b700000269

and is working.

Note, however, that the value displayed in the 'Assigned by' field is NOT preserved when an annotation is imported into a model. The 'Assigned by' value is changed to the Group selected by the curator who is creating the model.

There are a number of tickets out there that discuss 'Assigned by' values, but I'd have to review more of them to see if there's any open one specifically for dealing with this behavior. Note that there are also implications for model copy work. For now, I'll reference: https://github.com/geneontology/noctua/issues/459

vanaukenk commented 1 year ago

Done.