geneontology / noctua-form

2 stars 0 forks source link

Incomplete summary icon on Noctua form table #155

Closed vanaukenk closed 2 years ago

vanaukenk commented 2 years ago

@tmushayahama Here's an example where the annotation information entered via the Noctua form doesn't match what is shown in the summary icon. This gene has a CC annotation as well as an MF annotation:

image

tmushayahama commented 2 years ago

@vanaukenk do you the GO term on the existence starts and ends during. I thought we were not displaying extensions. Do you want me to display extensions?

vanaukenk commented 2 years ago

@tmushayahama No, I was actually referring to the GO CC annotation to 'cytosol' (occurs_in cytosol on the table).

vanaukenk commented 2 years ago

From discussion on a workbenches call - the icon is meant to indicate the form used rather than an indication of the information content of an entry in the table. I love the icon and it's an improvement over the previous text, e.g. Activity Unit, but I think the meaning of the filled in circles could be confusing to curators. Maybe a short-term fix would be to replace 'MF' with 'AU'?

vanaukenk commented 2 years ago

From 2021-11-04:

We'll keep the nice logo icon, but its information will reflect whether there are terms for each branch.

We'll also add back the column that indicates which implementation, i.e. create activity, bp only, cc only, of the form was used to create the original annotations.

Order in table: form used date go icon

vanaukenk commented 2 years ago

Note - this work is now being tracked in #146