geneontology / noctua-form

2 stars 0 forks source link

Missing annotations in Form when searching annotations #192

Closed pgaudet closed 1 year ago

pgaudet commented 2 years ago

Hi,

With the Swiss-Prot curators we noticed that when using the Search Annotation menu, not all annotations are returned - for example for human YAP (UniProt:P46937)

image

However there are annotations missing for example transcription coactivator activity IDA from PMID:18280240 is missing. This is an annotation that was done is 2010; shouldn't it be there?

Thanks, Pascale

@lionelbreuza @pmasson55 @vanaukenk @tmushayahama

tmushayahama commented 2 years ago

@balhoff @kltm was there any change to Golr or Neo?

kltm commented 2 years ago

@tmushayahama They both update either monthly or every other week. If there something specific you're digging after?

pgaudet commented 2 years ago

This impacts usability - all annotations should be available

vanaukenk commented 2 years ago

I've done some testing this morning to see if I can understand what the problem might be.

I tested searching existing MF annotations for a random set of genes/gene products for different species, with or without isoforms, and I can't find any missing annotations for any of them except human YAP1 (UniProtKB:P46937).

I also specifically tested other genes/gene products with annotations to 'transcription coactivator activity' and can find those when searching their MF annotations.

Lastly, since it's still available, I tried the Function Companion workbench in the graph editor and there I can find the missing human YAP1 MF annotations and import them successfully. The Assigned By field in the Noctua form table isn't displaying correctly for annotations imported with the Function Companion, but I don't know if that's at all related to the reported issue here. I suspect not.

Bottom line - I'll need to do some more systematic testing with the input of GO software developers to understand what's going on here.

kltm commented 1 year ago

@vanaukenk Should we chat about this at some point? What would be the best way forward here?

kltm commented 1 year ago

Taking a quick look at this with @pgaudet, it looks like the form is contacting the GOlr instance and finding docs, but they not seem to be rendered? I'm wondering if this is a "bug" bug (and maybe is an "ongoing" issue) or something that needs to be more systematically looked at?

pgaudet commented 1 year ago

@tmushayahama Can you please have a look ?

tmushayahama commented 1 year ago

Aghhh it's a very simple hiccup, apologies couldn't find it earlier. Thanks for the above comments/discussion. After some debugging, having exactly 100 results was a little suspicious. Then I remember, when we initially designed the search database for Noctua Form 1, we put limit of 100. so I believed it escaped all these years.

image

And for sure the count is 149 same as amigo image

So will just remove the limit. Actually, maybe increase the limit to some large number or lets think of a way. Pagination is not a viable options because results are not folded tagging @vanaukenk @kltm @pgaudet @ukemi

pgaudet commented 1 year ago

Hi @tmushayahama , thanks for finding this!! What's weird is that we see fewer than 100 results (but maybe that's the same problem).

I think we need to remove the limits, otherwise it defeats the purpose of that functionality @vanaukenk @ukemi

pgaudet commented 1 year ago

Can we prioritize this ? this is really impeding work.

vanaukenk commented 1 year ago

2023-03-23 workbenches call: we will try to get this fix in for tonight's maintenance outage.

vanaukenk commented 1 year ago

Testing after the 2023-03-23 Noctua maintenance outage:

I tested all MF annotations in AmiGO for human YAP1 (UniProtKB:P46937) and all of the terms, with the correct number of annotations, are now there in the search.

I also tested a subset of mouse Ctnnb1 BP annotations and everything looks okay there, too.