geneontology / noctua-form

2 stars 0 forks source link

Sprint 1 #201

Closed tmushayahama closed 1 year ago

tmushayahama commented 1 year ago

Issues

https://github.com/geneontology/noctua-form/issues/162 https://github.com/geneontology/noctua-form/issues/185 https://github.com/geneontology/noctua-landing-page/issues/47 https://github.com/geneontology/noctua-form/issues/177

Added

Announcement Banner Sample

Changed

Fix Evidence getting lost after adding an input
Added Uberon Life Stages on the happens during
Activity Date now taking the last modified individua or evidence

Testing

Also add other Individuals like add has_ouput, part of etc to check if the evidence is not lost
Edit the https://github.com/geneontology/noctua-announcements repo accordingly to see if the announcements change

tagging @vanaukenk @ukemi

vanaukenk commented 1 year ago

162 #185 #177 are tested and okay to move to production, but the announcements ticket needs more discussion and isn't ready to move to production.

@tmushayahama can you re-submit the PR without the announcements work/addition?

tmushayahama commented 1 year ago

@vanaukenk oh yes, it will not show up on production . This is only for dev.

vanaukenk commented 1 year ago

@tmushayahama But can we move the work for #162 #185 and #177 to production Noctua without also putting the announcements work into production? I've tested and approved those three tickets for production, but don't want to put the announcements onto production yet.

tmushayahama commented 1 year ago

@vanaukenk yes, that what I meant on above. The production will not have the announcement components displaying. The code is for the dev server now, but not for production. I am about to PR to production

vanaukenk commented 1 year ago

See: https://github.com/geneontology/noctua-form/pull/202

tmushayahama commented 1 year ago

@vanaukenk that's PR to production without the announcements .