geneontology / noctua-form

2 stars 0 forks source link

Sprint 3 #204

Closed tmushayahama closed 2 years ago

tmushayahama commented 2 years ago

Issue

tagging @vanaukenk @ukemi @pgaudet

vanaukenk commented 1 year ago

@tmushayahama

I'm testing the new comments feature on the noctua-form and one difference I've noticed between prod and dev is that when I change a title on prod and click 'save', the title immediately updates in the bar at the top of the page.

On noctua-dev now, though, that no longer happens after clicking 'save'. I had to refresh the page to see the new title.

Is this expected?

The automatic title update is preferred because it gives curators visual confirmation that the change they made has been made. Otherwise, they will wonder if the change worked.

vanaukenk commented 1 year ago

I have the same question for the comments feature.

Once a curator adds a comment and clicks on 'save' can the number by the comments bubble be updated?

Same thing for deleting a comment - it would be best if they number automatically updated after a curator clicks 'save'.

vanaukenk commented 1 year ago

Also, the new grouping of tools on the Noctua landing page looks fine to me and all the links work fine.

tmushayahama commented 1 year ago

@vanaukenk for me it is changing fine without refresh after pressing "save" button. even the comments number changes.

vanaukenk commented 1 year ago

Hmmm....I'm still seeing the same behavior I saw earlier on noctua-dev. Let's screen share so you can see what I'm doing.

vanaukenk commented 1 year ago

Discussed with @tmushayahama Metadata will only update on models with individuals, so we decided to create a new ticket to add an error message pop-up that alerts curators not to edit metadata until they've created at least one annotation.

See: https://github.com/geneontology/noctua-form/issues/205