geneontology / noctua-form

2 stars 0 forks source link

bug in noctura form for CC annotation? #222

Closed LiNiMGI closed 1 year ago

LiNiMGI commented 1 year ago

@tmushayahama @vanaukenk seems to me that after the Noctua maintenance outage on May 25th, noctua form for CC annotation changed: when click the "+" sign on the right of the gene product, there are 7 options curators can chose to enter the data, but: no located in CC available.

I am also not sure: do we really want to put the 7 options there?

thank for the help, Li

suzialeksander commented 1 year ago

image Thanks for reporting this @LiNiMGI

To add, it seems I can't make some "standard annotations"- if I select located_in (since is_active_in is disabled), there's no option to annotate to GO:0005737; options in the drop-down include XAO:0005039 or dendrite cytoplasm.

vanaukenk commented 1 year ago

We'll discuss this at the Thursday workbenches call.

In the meantime, curators can use the graph editor to make these annotations, but will have to search in the relations pop-up window for 'located in'.

Apologies for the new bug.

krchristie commented 1 year ago

This pull-down menu in the BP form is also similarly affected, though a thing of importance that is now missing is that there is no option to make an extension using a cell type.

20230530-NoctuaForm-extensionPulldown

vanaukenk commented 1 year ago

We discussed this on the Noctua workbenches call.

@balhoff is it possible that this issue is related to replacing CARO with UBERON?

In the ShEx we have:

PREFIX GoAnatomicalEntity: http://purl.obolibrary.org/obo/CARO_0000000

but if that CARO term is no longer being used, then perhaps that's why we've 'lost' some GO CC terms in Noctua?

I can update the ShEx with the appropriate UBERON term, if necessary.

balhoff commented 1 year ago

@vanaukenk I didn't think that change had propagated out to places that would affect this yet. But it's possible! It seems high priority for me to find and update references to CARO throughout all of GO.

ukemi commented 1 year ago

Note that it might not just be a 1:1 switch if the UBERON class doesn't include cellular anatomical entity as a subclass. I can't rember exactly how virion component fits into all this.

balhoff commented 1 year ago

@ukemi it should be a simple swap based on what we decided about what the Uberon terms would mean. But we will need to update some bridge axioms in the ontology repo to connect up.

balhoff commented 1 year ago

This should be fixed by the next GO snapshot and subsequent refresh of the ontologies used by Noctua.

LiNiMGI commented 1 year ago

@vanaukenk @tmushayahama What’s the status on fixing this bug in the form? This bug makes both the CC and the BP forms essentially unusable for MGI.

At our weekly GO meeting, David@ukemi said that fixing this would be part of the project on extensions. If the extensions project is going to take a long time, is there any possibility to rollback the changes that created this problem in Noctua production and move the extensions project to Noctua Dev, so that we can use the form to make our annotations again?

Thanks!

vanaukenk commented 1 year ago

@LiNiMGI I'm sorry this bug caused such havoc. My understanding, though, is that this was an ontology issue, so we don't need to rollback any Noctua code.

@kltm - do you think we could try a neo update to see if that fixes this problem? Thank you.

EDIT: @kltm - let me talk to @LiNiMGI to see if I can confirm that problem. Right now, the CC only form looked to be working to me.

vanaukenk commented 1 year ago

Okay - late-breaking Friday update :-)

The ontology fix that @balhoff and @pgaudet put in DID fix the problem.

There was some confusion, though, because the word 'Anatomy' underneath relations like 'located in' was taken to mean something other than GO CC. I think this is a case where perhaps too much of the underlying data model gets exposed in the tool and we should think about updating the UI to make things clearer.

So @kltm - no need to update neo and apologies for the false alarm.

vanaukenk commented 1 year ago

I also just double-checked in the BP only form and this is working okay there, too.

@LiNiMGI @krchristie - if you encounter any other issues, please reopen this ticket. Thx.

tmushayahama commented 1 year ago

@vanaukenk @LiNiMGI @kltm I was looking at the previous version of NF and the question above, the only difference was words located in CC to located in Anatomy. Reading carefully what @LiNiMGI said "7 options curators can chose to enter the data, but: no located in CC available." I counted 7 options from the screenshot, SO I can conclude, I am suspecting it is the word Anatomy which might be confusing as per @krchristie comment https://github.com/geneontology/noctua-form/issues/223 located in CC is now located in Anatomy. Thanks @krchristie @LiNiMGI Very sorry for the confusion

krchristie commented 1 year ago

I also think that the form could be made easier for curators to use if you could select the term before having to select the relationship, because the way it works right now, if you select the wrong relationship, you can't even get the term you want as the autocomplete only offers terms appropriate for that relationship. Since curators generally know what term they want, but not necessarily which relationship is allowed/appropriate, it would be a much better work flow for curators if we could select the GO term first, and THEN have the interface guide us as to which relationships are allowed.

See comments in this ticket: Curation flow in CC only form seems backwards and awkward for curators #224