geneontology / noctua-form

2 stars 0 forks source link

Editing Table after creating activity #237

Closed tmushayahama closed 1 year ago

tmushayahama commented 1 year ago

Issue

https://github.com/geneontology/noctua-form/issues/236

Changed

Ability to edit using the pencil on the table

Testing

Please note this is not https://github.com/geneontology/noctua-form/issues/234 Focus on this is the editing.

I had to quickly fix this so that we can push to production soon. I will do more thorough testing

tagging @vanaukenk @ukemi @kltm @linimgi

LiNiMGI commented 1 year ago

Thanks @tmushayahama One problem I noticed so far: For a process only annotation, when tried to modify the molecular_function root term in the table, after save, the process annotation disappeared from the table, though it still shows up in graph view and annotation preview.

example: http://noctua-dev.berkeleybop.org/workbench/noctua-form/?model_id=gomodel%3A64f8fbd000000030 I first added a new process only annotation for mouse "Trp53: DNA repair GO:0006281". I then edit the molecular_function root term to 'DNA binding" After save, i can't not see the "Trp53: DNA repair" annotation anymore, though it still exist in graph view and annotation preview.

Also, in the table the CC only annotation still has “GP info not available” as before.

will do some more test tomorrow :)