search

geneontology / noctua-form

2 stars 0 forks source link

Side menu items for inserting types #96

Open tmushayahama opened 4 years ago

tmushayahama commented 4 years ago

As seen from https://github.com/geneontology/noctua-form/issues/93, wrong insert point can lead to bugs and wrong annotations. Now menu updates when something is already inserted

As an ongoing way to align with shex, a quick fix was not to allow some of the correct shex relations like insert BP though which will be incorrect in an activity unit.

For example, GO shape can insert a BP through a causal edge, but not allowed for noctua form image

tag: @vanaukenk (@goodb just showing, this is our attempt to align with shex :). So this menu is dynamic for a shex-like object. Help later on )

tmushayahama commented 4 years ago

There is still a tiny bug . If a cell type is added, the next level should be added from that cell type not CC. Fix will be there soon

image

@vanaukenk