geneontology / noctua-models

This is the data repository for the models created and edited with the Noctua tool stack for GO.
http://noctua.geneontology.org/
Creative Commons Attribution 4.0 International
10 stars 3 forks source link

Consistence Date Format for models (sorting problems) #174

Open tmushayahama opened 3 years ago

tmushayahama commented 3 years ago

Some of the new ZFIN models and imports have a date of format yyyy-m-d without padding i.e. 2020-3-1 and while some created with noctua have format yyyy-mm-dd i.e. 2020-03-01. From sorting point of view, these are different dates since dates are treated as strings in noctua search api. Is it possible to just have same format yyyy-mm-dd Otherwise landing page search will not sort properly for default view (recent models)

As you can see here, by default this is sorted by recent date and March appears recent than September

image

yyyy-m-d format image

yyyy-mm-dd format image

tagging @dustine32 @kltm @ukemi @lpalbou @vanaukenk

dustine32 commented 3 years ago

Ooo, good catch @tmushayahama! These YYYY-M-D dates are likely all coming from MOD import models, and I just happened to fix this (at @kltm's urging) in the MOD import conversion code. See https://github.com/biolink/ontobio/commit/c862bd271a5bb5d62298aafe42a0217737c07f9d. Though you won't notice the corrections until we regenerate all of the MOD import models. I think these are fixed for MGI and WB, but not yet ZFIN. ZFIN should just be a matter of days.