search

geneontology / noctua-models

This is the data repository for the models created and edited with the Noctua tool stack for GO.
http://noctua.geneontology.org/
Creative Commons Attribution 4.0 International
10 stars 3 forks source link

Updated SynGO models from geneontology/syngo-go-cams#2 #235

Closed dustine32 closed 2 years ago

dustine32 commented 2 years ago

Intended for merge into master whenever @vanaukenk or other testers approve this is OK to go.

This will have effects in the GO pipeline related to https://github.com/geneontology/go-site/issues/1847:

  1. ECO codes updated in https://github.com/geneontology/syngo2lego_data_conversion/issues/5 will allow these (previously failing) annotations to pass QC and so will increase annotation count.
  2. Increase in SynGO models since last update, 2196->3241 will also increase annotation count substantially. Mostly in mouse but likely also in other SynGO-annotated organisms.
vanaukenk commented 2 years ago

@thomaspd - please let me know if you plan to look over these models on noctua-dev with Frank before they go onto noctua-production. Thanks.

@dustine32 @kltm

dustine32 commented 2 years ago

Added missing model SYNGO:1805. Details in https://github.com/geneontology/syngo-go-cams/pull/4.

dustine32 commented 2 years ago

Frank approves! From 2022-06-30 email:

I've reviewd a dozen random models on the noctua-dev site you linked, looks fine to me !

kltm commented 2 years ago

Great--this has already been added to the list for July: https://github.com/geneontology/noctua/issues/782

dustine32 commented 2 years ago

@kltm I see there are now conflicts from the last outage auto-commit flush https://github.com/geneontology/noctua-models/commit/9dabc1571a32c62f84cf19c40779314c596f12f9 but I can just reapply the SYNGO_ models to fix. Should I do this now or wait until just before the 2022-07-14 merge/outage?

kltm commented 2 years ago

Yes, reapplication would make the most sense. This will keep happening as we do a reordering to make the diffs easier. In the future, if this was just an "add on" repo, we could avoid that.