search

geneontology / noctua-standard-annotations

0 stars 0 forks source link

Default gp2 term relation for protein-containing complex should be 'part of' #11

Closed vanaukenk closed 1 month ago

vanaukenk commented 3 months ago

The default gp2term relation for protein-containing complex is 'part of'

To reproduce:

Enter: gp protein-containing complex - see current default is set to 'is active in'

The only gp2term relation for protein-containing complex is 'part of' and the annotation should display on the table.

vanaukenk commented 2 months ago

Tested with different types of annotation subjects (i.e. gene, sequence, protein, protein-containing complex) and adding 'part of' relation before selecting GO term or selecting GO term first and letting the tool default to the gp2term relation for a PCC annotation.

All is working as expected, except when a protein-containing complex is the subject, I could select a PCC GO term, no relation was selected either by default or manually by a curator, but the SAVE button wasn't disabled so I could click SAVE but no annotation was saved.

@tmushayahama @thomaspd - generally this is all working fine, but we need to decide what we're going to do with protein-containing complexes as subjects of standard annotation. I'll make a separate ticket for that.

vanaukenk commented 1 month ago

This is now fixed.